On Thu, 2007-10-18 at 19:48 +0400, Oleg Nesterov wrote: > > +void flush_work_sync(struct work_struct *work) > If we really the new helper, perhaps we can make it a bit better? > > 1. Modify insert_work() to take the "struct list_head *at" parameter instead > of "int tail". I think this patch will also cleanup the code a bit, and > shrink a couple of bytes from .text > > 2. flush_work_sync() inserts a barrier right after this work and blocks. > We still need some retry logic to handle the queueing is in progress > of course, but we won't spin waiting for the other works. 3. Add lockdep annotation like the other API. :) Andrew just sent my patch (used to be two patches by somebody's request but that's fine) titled "workqueue: debug flushing deadlocks with lockdep" to Linus. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
- References:
- Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes
- From: Jarek Poplawski <[email protected]>
- Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes
- From: "Maciej W. Rozycki" <[email protected]>
- Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes
- From: Jarek Poplawski <[email protected]>
- Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes
- From: "Maciej W. Rozycki" <[email protected]>
- Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes
- From: Jarek Poplawski <[email protected]>
- Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes
- From: Jarek Poplawski <[email protected]>
- [PATCH] flush_work_sync vs. flush_scheduled_work Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes
- From: Jarek Poplawski <[email protected]>
- Re: [PATCH] flush_work_sync vs. flush_scheduled_work Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes
- From: Oleg Nesterov <[email protected]>
- Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes
- Prev by Date: [PATCH 9/9] irq-remove: misc fixes and cleanups
- Next by Date: Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes
- Previous by thread: Re: [PATCH] flush_work_sync vs. flush_scheduled_work Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes
- Next by thread: Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes
- Index(es):
 |