Re: [PATCH 0/4] Fix race between sk_filter reassign and sk_clone()

David Miller wrote:
> From: Olof Johansson <[email protected]>
> Date: Thu, 18 Oct 2007 21:29:47 -0500
> 
>> So, looks like rcu_dereference() returned NULL. I don't know the
>> filter code at all, but it seems like it might be a valid case?
>> sk_detach_filter() seems to handle a NULL sk_filter, at least.
>>
>>
>> So, this needs review by someone who knows the filter, but it fixes the
>> problem for me:

Yes. The NULL filter is a valid case, when there are no
filters attached at all. So this fix is correct.

Thanks, Olof. Sorry, Dave :(

>>
>> Signed-off-by: Olof Johansson <[email protected]>

Acked-by: Pavel Emelyanov <[email protected]>

> I've applied this for now to my net-2.6 tree, thanks Olof
> for tracking this down.
> 
> Pavel please take a look at this and let me know if it should
> fixed in some other way.
> 
> Thanks!
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 0/4] Fix race between sk_filter reassign and sk_clone()
    • From: David Miller <[email protected]>

• References:
  • Re: [PATCH 0/4] Fix race between sk_filter reassign and sk_clone()
    • From: Olof Johansson <[email protected]>
  • Re: [PATCH 0/4] Fix race between sk_filter reassign and sk_clone()
    • From: David Miller <[email protected]>

• Prev by Date: [PATCH] atm/stallion/ucb1400_ts: remove needless use of irq handler first arg
• Next by Date: Re: [PATCH] flush_work_sync vs. flush_scheduled_work Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes
• Previous by thread: Re: [PATCH 0/4] Fix race between sk_filter reassign and sk_clone()
• Next by thread: Re: [PATCH 0/4] Fix race between sk_filter reassign and sk_clone()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]