On Thursday 18 October 2007, Benjamin Herrenschmidt wrote:
>
> On Thu, 2007-10-18 at 16:02 +0400, Sergei Shtylyov wrote:
> > Benjamin Herrenschmidt wrote:
> >
> > > The siimage use an incorrect construct to access the other drive
> > > of a pair, causing it to access beyond an array boundary on non-0
> > > interfaces. This fixes it by using the new ide_get_paired_drive()
> > > hepler instead.
> >
> > > Signed-off-by: Benjamin Herrenschmidt <[email protected]>
> >
> > Please update the driver version in the driver's heading comment. Otherwise
> >
> > Acked-by: Sergei Shtylyov <[email protected]>
>
> I don't believe much in driver versions in tree... the kernel version is
> what matter... Bart, what's your stance there ?
Similar opinion here but sometimes driver versions are useful, i.e.:
* during development or while debugging regressions to distinguish
real changes (which have to update driver version) from the core
changes and trivial cleanups (which don't do this)
* bugreports with partial dmesg info (hmm, doesn't matter for IDE
currently since we don't print this info - patches are welcomed)
* maybe some other that I forgot :)
I updated siimage driver version in separate commit
(no need to do it for cs5535 since it lacks driver version).
Thanks,
Bart
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
