Re: latest checkpatch

[Andy Whitcroft <apw@shadowen.org>]

On Thu, Oct 18, 2007 at 08:25:21PM +0100, Andy Whitcroft wrote:
> On Thu, Oct 18, 2007 at 01:13:52PM +0200, Ingo Molnar wrote:
> > 
> > latest checkpatch.pl works really well on sched.c.
> > 
> > there's only one problem left, this bogus false positive warning 
> > reappeared:
> > 
> >   WARNING: braces {} are not necessary for single statement blocks
> >   #5710: FILE: sched.c:5710:
> >   +       if (parent->groups == parent->groups->next) {
> >   +               pflags &= ~(SD_LOAD_BALANCE |
> >   +                               SD_BALANCE_NEWIDLE |
> >   +                               SD_BALANCE_FORK |
> >   +                               SD_BALANCE_EXEC |
> >   +                               SD_SHARE_CPUPOWER |
> >   +                               SD_SHARE_PKG_RESOURCES);
> >   +       }
> > 
> > (there's another place in sched.c that trips this up too.)

Ok, checkpatch.pl-next should now no longer trip up on this statement.

-apw
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/