Re: [PATCH] synchronize_irq needs a barrier

Benjamin Herrenschmidt <[email protected]> wrote:
> 
> Note that some kind of read barrier or compiler barrier should be needed
> regardless, or we are just not sync'ing with anything at all (we may
> have loaded the value ages ago and thus operate on a totally stale
> value). I prefer a full barrier to also ensure all previous stores are
> pushed out.

We already have a compiler barrier there in the form of cpu_relax.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] synchronize_irq needs a barrier
    • From: Benjamin Herrenschmidt <[email protected]>

• References:
  • Re: [PATCH] synchronize_irq needs a barrier
    • From: Benjamin Herrenschmidt <[email protected]>

• Prev by Date: Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes
• Next by Date: Re: [PATCH] Map volume and brightness events on thinkpads
• Previous by thread: Re: [NET]: Fix possible dev_deactivate race condition
• Next by thread: Re: [PATCH] synchronize_irq needs a barrier
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]