Re: [bug] ata subsystem related crash with latest -git

On Oct. 18, 2007, 16:05 +0200, Jens Axboe <[email protected]> wrote:
> On Thu, Oct 18 2007, Jens Axboe wrote:
>> On Thu, Oct 18 2007, Benny Halevy wrote:
>>>>  	return sg;
>>>>  }
>>>> @@ -83,6 +96,9 @@ static inline struct scatterlist *sg_last(struct scatterlist *sgl,
>>>>  		ret = sg;
>>>>  
>>>>  #endif
>>>> +#ifdef CONFIG_DEBUG_SG
>>>> +	BUG_ON(sgl[0].sg_magic != SG_MAGIC);
>>> can it also do BUG_ON(!sg_is_last(sg))?
>> That would make sense, definitely. I'll add that.
> 
>         BUG_ON(!sg_is_last(ret));
> 
> it should be, not sg. That's what I merged.
> 
right. of course.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [bug] ata subsystem related crash with latest -git
    • From: Jens Axboe <[email protected]>

• References:
  • Re: [bug] ata subsystem related crash with latest -git
    • From: Jens Axboe <[email protected]>
  • Re: [bug] ata subsystem related crash with latest -git
    • From: David Miller <[email protected]>
  • Re: [bug] ata subsystem related crash with latest -git
    • From: Jens Axboe <[email protected]>
  • Re: [bug] ata subsystem related crash with latest -git
    • From: David Miller <[email protected]>
  • Re: [bug] ata subsystem related crash with latest -git
    • From: Jens Axboe <[email protected]>
  • Re: [bug] ata subsystem related crash with latest -git
    • From: Jens Axboe <[email protected]>
  • Re: [bug] ata subsystem related crash with latest -git
    • From: Benny Halevy <[email protected]>
  • Re: [bug] ata subsystem related crash with latest -git
    • From: Jens Axboe <[email protected]>
  • Re: [bug] ata subsystem related crash with latest -git
    • From: Jens Axboe <[email protected]>

• Prev by Date: [PATCH] Fix a build error when BLOCK=n
• Next by Date: Re: How Inactive may be much greather than cached?
• Previous by thread: Re: [bug] ata subsystem related crash with latest -git
• Next by thread: Re: [bug] ata subsystem related crash with latest -git
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]