Jens Axboe wrote:
index 4df8311..b858183 100644 --- a/drivers/ata/sata_mv.c +++ b/drivers/ata/sata_mv.c @@ -1139,6 +1139,7 @@ static void mv_fill_sg(struct ata_queued_cmd *qc) struct mv_port_priv *pp = qc->ap->private_data; struct scatterlist *sg; struct mv_sg *mv_sg; + int end_marked = 0;mv_sg = pp->sg_tbl;ata_for_each_sg(sg, qc) { @@ -1159,13 +1160,15 @@ static void mv_fill_sg(struct ata_queued_cmd *qc) sg_len -= len; addr += len;- if (!sg_len && ata_sg_is_last(sg, qc))+ if (!sg_len && ata_sg_is_last(sg, qc)) { mv_sg->flags_size |= cpu_to_le32(EPRD_FLAG_END_OF_TBL); + end_marked++; + }mv_sg++;} - } + BUG_ON(end_marked != 1);
Your BUG_ON() does indeed trip, here.Its surprising that other folks don't explode, considering that mv_fill_sg() intentionally mirrors the logic in ata_fill_sg().
Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [bug] ata subsystem related crash with latest -git
- From: Jens Axboe <[email protected]>
- Re: [bug] ata subsystem related crash with latest -git
- References:
- Re: [bug] block subsystem related crash with latest -git
- From: Jens Axboe <[email protected]>
- Re: [bug] block subsystem related crash with latest -git
- From: Ingo Molnar <[email protected]>
- [bug] ata subsystem related crash with latest -git
- From: Ingo Molnar <[email protected]>
- Re: [bug] ata subsystem related crash with latest -git
- From: Jens Axboe <[email protected]>
- Re: [bug] ata subsystem related crash with latest -git
- From: Jens Axboe <[email protected]>
- Re: [bug] ata subsystem related crash with latest -git
- From: Ingo Molnar <[email protected]>
- Re: [bug] ata subsystem related crash with latest -git
- From: Linus Torvalds <[email protected]>
- Re: [bug] ata subsystem related crash with latest -git
- From: Jens Axboe <[email protected]>
- Re: [bug] ata subsystem related crash with latest -git
- From: Ingo Molnar <[email protected]>
- Re: [bug] ata subsystem related crash with latest -git
- From: Jeff Garzik <[email protected]>
- Re: [bug] ata subsystem related crash with latest -git
- From: Jens Axboe <[email protected]>
- Re: [bug] block subsystem related crash with latest -git
- Prev by Date: Re: [RFC PATCH 2/4] Rename lock_cpu_hotplug to get_online_cpus
- Next by Date: Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block size
- Previous by thread: Re: [bug] ata subsystem related crash with latest -git
- Next by thread: Re: [bug] ata subsystem related crash with latest -git
- Index(es):