Re: [PATCH] vortex_up should initialize "err"

On Wed, Oct 17, 2007 at 08:28:36PM -0400, Jeff Garzik wrote:
> Badari Pulavarty wrote:
> >Simple compile warning fix. (against 2.6.23-git12)
> >
> >Thanks,
> >Badari
> >
> >vortex_up() should initialize 'err' for a successful return.
> >
> >drivers/net/3c59x.c: In function `vortex_up':
> >drivers/net/3c59x.c:1494: warning: `err' might be used uninitialized in 
> >this function
> 
> applied as an obvious bug fix (Steffen added to CC)
> 

Hm, we had already the 3c59x-fix-uninitialized-variable-bug.patch from
Satyam Sharma in -mm to fix this, but the patch was removed from -mm
some time ago. Andrew, what happened to this one?

However, this issue should be fixed.

Thanks,

Steffen
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH] vortex_up should initialize "err"
  - From: Andrew Morton <[email protected]>

References:
- [PATCH] vortex_up should initialize "err"
  - From: Badari Pulavarty <[email protected]>
- Re: [PATCH] vortex_up should initialize "err"
  - From: Jeff Garzik <[email protected]>

Prev by Date: Re: hda-intel: no soundcard with current linus' git tree
Next by Date: [PATCH 1/2] add tunable_notifier function ,take2
Previous by thread: Re: [PATCH] vortex_up should initialize "err"
Next by thread: Re: [PATCH] vortex_up should initialize "err"
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]