RE: [PATCH 5/5] I/OAT: Add completion callback for async_tx interface use

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>From: Andrew Morton [mailto:[email protected]] 
>
>On Wed, 17 Oct 2007 17:14:39 -0700
>Shannon Nelson <[email protected]> wrote:
[...]
>> +static dma_async_tx_callback ioat_dma_test_callback(void 
>*dma_async_param)
>> +{
>> +	printk(KERN_ERR "ioatdma: ioat_dma_test_callback(0x%04llx)\n",
>> +		(u64)dma_async_param);
>> +	return 0;
>> +}
>
>This wanted to be `return NULL'.  I'll fix.

Thanks.

>
>>  /**
>>   * ioat_dma_self_test - Perform a IOAT transaction to 
>verify the HW works.
>>   * @device: device to be tested
>> @@ -691,6 +715,8 @@ static int ioat_dma_self_test(struct 
>ioatdma_device *device)
>>  	addr = dma_map_single(dma_chan->device->dev, dest, 
>IOAT_TEST_SIZE,
>>  			DMA_FROM_DEVICE);
>>  	ioat_set_dest(addr, tx, 0);
>> +	tx->callback = (void *)ioat_dma_test_callback;
>
>This cast is unneeded, surely?  It had better be..
>
>> +	tx->callback_param = (void *)0x8086;
>
>eh?

I suppose I could have used "42"...

sln
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux