From: Alan Stern <[email protected]>
Date: Wed, 17 Oct 2007 11:51:57 -0400 (EDT)
> > + break;
> > + }
> > + if (limit_1 < 0) {
> > + ohci_warn(ohci, "Root port outer-loop reset timeout, "
> > + "now[%04x] reset_done[%04x]\n",
> > + now, reset_done);
> > + }
>
> What reason is there for having two warning messages? One ought to be
> enough.
In my patch it was possible for the inner loop one to succeed, but the
outer one to not do so.
In your's this is not the case so I guess it's OK.
I wonder if it's so wise trying to do two things at once. Here we are
adding the loop timeouts, and also changing to using jiffies based
timeouts rather than a chip timer register based one.
I preferred my patches because it solved one single problem, the lack
of loop limits. The timeout mechanism could have been changed in
another followon patch.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
