Re: [PATCH] Map volume and brightness events on thinkpads

[Henrique de Moraes Holschuh <hmh@hmh.eng.br>]

On Tue, 16 Oct 2007, Jesse Barnes wrote:
> > Last time the issue was brought up (and I do believe it was because
> > of thinkpad-acpi :-) ), he made it clear that any events you are to
> > act upon are fine in input, but events that are just notifications
> > (i.e. the firmware already did the action) are not.
> 
> Ah yeah, I agree with that.  Regular events should be uevents or 
> something, not input events.  Actual keyboard keys though (whether they 
> generate firmware event messages or actual scancodes) should probably 
> go through the input layer.  I thought that's what Jeremy's patch was 
> doing, maybe I didn't look closely enough.

The patch adds keycodes for "keys" that are acually notifications on many
thinkpads.  And that is the problem, please refer to the rest of the thread
for more details...

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/