Re: [patch] forcedeth: fix the NAPI poll function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ingo Molnar wrote:
* Jeff Garzik <[email protected]> wrote:

The compiler certainly doesn't care, and IMO it prevents bugs.
agreed. Do you have an uptodate patch/git-URI for the forcedeth rewrite you did? I can throw it into the testbed.
Branch 'fe-lock' of
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git

It works here locally, but at this very minute I am rewriting those changesets yet again :)

FYI, looks good so far, ontop of Linus' latest -git tree.

btw., one thing i always found weird about forcedeth is that it generates an extra ~100 irqs per second even when there's no network traffic:

 11:      89752    XT-PIC-XT        eth0
 11:      89854    XT-PIC-XT        eth0
 11:      89955    XT-PIC-XT        eth0
 11:      90056    XT-PIC-XT        eth0
 11:      90157    XT-PIC-XT        eth0

(irq count snapshot every second). Just in case it's easy to fix ...


May I presume that behavior occurs in both mainline and my fe-lock branch?

That is likely the NIC's timer irq, which is programmed to kick the irq handler every so often. DEV_NEED_TIMERIRQ is a starting point, as well as "Known bugs" at the top of forcedeth.c, if you're curious.

I'm _betting_ that some of that can be eliminated, but we'll see...

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux