Re: [PATCH] Make m68k cross compile like every other architecture.

[Rob Landley <rob@landley.net>]

On Monday 15 October 2007 3:25:35 pm Geert Uytterhoeven wrote:
> 64-bit parisc tests if /usr/bin/hppa64-linux-gnu- exists.
> If yes, it sets CROSS_COMPILE to hppa64-linux-gnu-.
> If no, it sets CROSS_COMPILE to hppa64-linux-
>
> 32-bit parisc unconditionally sets CROSS_COMPILE to hppa-linux-.
>
> This still breaks Rob's setup if his compiler is called differently.

Another thing to take into account is that kconfig was recently changed to 
save ARCH and CROSS_COMPILE in the .config file:

http://lwn.net/Articles/253889/

Presumably that means you'd only have to specify your arch and cross compiler 
during config, and then if you re-used that config it would re-use those 
settings.  But the existing makefile discards anything that isn't explicitly 
overridden on the make command line at each stage of the build.

It seems to me any fix should only reset CROSS_COMPILE if there isn't already 
a value for it.  (Otherwise there's a potentially subtle bug where a year 
from now you might have "m68k-linux-gnu-gcc" and "m68k-linux-gnu-pcc" and 
want to compare the results of building with the different compilers.)

I still lean towards considering any attempt to cross compile without setting 
CROSS_COMPILE an error, and not guessing at what the user meant.  But perhaps 
that's just personal preference...

Rob
-- 
"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/