Re: [PATCH] git scsi misc include fix

[Paul Jackson <pj@sgi.com>]

James wrote:
> The requirement for struct scatterlist is the same
> before and after the gid scsi-misc patch. 

Not so.  The git-scsi-misc.patch in 2.6.23-mm1 clearly adds the line:

    struct scatterlist sense_sgl;

as part of the added struct scsi_eh_save in scsi/scsi_eh.h.

This bit me while I was doing a bisection on 2.6.23-mm1, for another
problem, in git-sched, which is discussed in the lkml thread:

    git-sched patch won't boot on SN arch, 2.6.23-mm1

This is using sn2_defconfig.  The full 2.6.23-mm1 patch set builds ok,
because another patch, git-block.patch as I recall, includes
scatterlist.h some other way, but for the following range of patches in
2.6.23-mm1, on the configuration sn2_defconfig, the build is broken,
due to 'struct scatterlist' being an incomplete type:

    git-scsi-misc.patch
    git-scsi-misc-include-fix.patch
    git-scsi-misc-fixup.patch
    qla2xxx-printk-fixes.patch
    pci-error-recovery-symbios-scsi-base-support.patch
    pci-error-recovery-symbios-scsi-first-failure.patch
    nsp32_restart_autoscsi-remove-error-check.patch
    scsi-send-media-state-change-modification-events.patch
    scsi-early-detection-of-medium-not-present-updated.patch
    mptbase-reset-ioc-initiator-during-pci-resume.patch
    scsi-use-notifier-chain-for-asynchronous-event.patch
    initio-fix-conflict-when-loading-driver.patch
    git-block.patch

> it should also fail with vanilla 2.6.23

I don't know about the vanilla 2.6.23 case.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/