Re: [PATCH 4/11] maps3: introduce a generic page walker

[Dave Hansen <haveblue@us.ibm.com>]

On Mon, 2007-10-15 at 15:40 -0700, Jeremy Fitzhardinge wrote:
> Can pte_hole be used to create new mappings while we're traversing the
> pagetable?  Apparently not, because it continues after calling it. 

For now, we should probably document that these functions assume that
the appropriate locks are held, and that there are no changes being made
to the pagetables as we walk.

However, I can see that people might want to use these in the future for
establishing ptes.  Perhaps a special code coming back from the
->pte_hole() function could indicate changes were made to the
pagetables.  I guess we could at least retry part of the loop where the
hole call was made, like:

+int walk_page_range(struct mm_struct *mm,...
+{
...
+       pgd = pgd_offset(mm, addr);
+       do {
+               next = pgd_addr_end(addr, end);
+               if (pgd_none_or_clear_bad(pgd)) {
+                       if (walk->pte_hole)
+                               err = walk->pte_hole(addr, next, private);
			if (err == -EAGAIN) { // or whatever we want
				pgd--;
				err = 0;
			}
+                       if (err)
+                               break;
+                       continue;
+               }

That wouldn't allow changes behind the walker, but it should allow them
in the range that was walked by the ->pte_hole() function.

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/