Re: asm-x86/* exported headers using CONFIG_X86_32

[Thomas Gleixner <tglx@linutronix.de>]

On Tue, 16 Oct 2007, Arnd Bergmann wrote:
> While looking through the new header files, I noticed lots of occurences
> of #ifdef CONFIG_X86_32 in headers files exported for glibc.
> 
> This is fundamentally broken because user applications including them
> do not know about any CONFIG_* symbols, and if they did, those
> would incorrectly describe the ABI.
> 
> I guess in most cases, the headers that are interesting to user space
> can simply be merged without any such #ifdef remaining, but those
> that are still needed should be converted to use #ifdef __x86_64__,
> which is set by the compiler.
> This is how the other architectures avoid this particular problem.

Yup, they slipped through. I have fixups in my pile already. Will send
them tomorrow when I'm actually awake.

     tglx

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/