Re: [patch] forcedeth: fix the NAPI poll function

Jeff Garzik wrote:

--- linux.orig/drivers/net/forcedeth.c
+++ linux/drivers/net/forcedeth.c
@@ -2274,7 +2274,7 @@ static int nv_rx_process(struct net_devi

while((np->get_rx.orig != np->put_rx.orig) && !((flags = le32_to_cpu(np->get_rx.orig->flaglen)) & NV_RX_AVAIL) &&

-        (rx_processed_cnt++ < limit)) {
+        (++rx_processed_cnt < limit)) {

dprintk(KERN_DEBUG "%s: nv_rx_process: flags 0x%x.\n",

                     dev->name, flags);
@@ -2412,7 +2412,7 @@ static int nv_rx_process_optimized(struc

while((np->get_rx.ex != np->put_rx.ex) && !((flags = le32_to_cpu(np->get_rx.ex->flaglen)) & NV_RX2_AVAIL) &&

-          (rx_processed_cnt++ < limit)) {
+          (++rx_processed_cnt < limit)) {

Though it wasn't clear, that's an ACK

I'll push the patch if nobody else beats me to it.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • WARNING: at net/core/dev.c:2161 net_rx_action()
    • From: Ingo Molnar <[email protected]>
  • Re: WARNING: at net/core/dev.c:2161 net_rx_action()
    • From: David Miller <[email protected]>
  • Re: WARNING: at net/core/dev.c:2161 net_rx_action()
    • From: Ingo Molnar <[email protected]>
  • Re: WARNING: at net/core/dev.c:2161 net_rx_action()
    • From: Ingo Molnar <[email protected]>
  • [patch] forcedeth: fix the NAPI poll function
    • From: Ingo Molnar <[email protected]>
  • Re: [patch] forcedeth: fix the NAPI poll function
    • From: Jeff Garzik <[email protected]>

• Prev by Date: [PATCH] rd: Preserve the dirty bit in init_page_buffers()
• Next by Date: [PATCH] rd: Mark ramdisk buffers heads dirty
• Previous by thread: Re: [patch] forcedeth: fix the NAPI poll function
• Next by thread: Re: [patch] forcedeth: fix the NAPI poll function
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]