Re: [PATCH 3/3] Blackfin serial driver: this driver enable SPORTs on Blackfin emulate UART

["Mike Frysinger" <vapier.adi@gmail.com>]

On 10/15/07, Andrew Morton <akpm@linux-foundation.org> wrote:
> > +config SERIAL_BFIN_SPORT
> > +     tristate "Blackfin SPORT emulate UART (EXPERIMENTAL)"
> > +     depends on BFIN && EXPERIMENTAL
> > +     select SERIAL_CORE
> > +     help
> > +       Enble support SPORT emulate UART on Blackfin series.
>
> There's a typo there.  Also the text is pretty meaningless - I'd fix it up
> but I'm not sure what it's trying to tell us!

here it is in english ;)

This driver emulates a standard UART using the SPORT peripherals on a
Blackfin processor.

> > +     snprintf(buffer, 20, "%s rx", up->name);
> > +     retval = request_irq(up->rx_irq, sport_uart_rx_irq, IRQF_SAMPLE_RANDOM, buffer, up);
> > +     if (retval) {
> > +             printk(KERN_ERR "Unable to request interrupt %s\n", buffer);
> > +             return retval;
> > +     }
> > +
> > +     snprintf(buffer, 20, "%s tx", up->name);
> > +     retval = request_irq(up->tx_irq, sport_uart_tx_irq, IRQF_SAMPLE_RANDOM, buffer, up);
> > +     if (retval) {
> > +             printk(KERN_ERR "Unable to request interrupt %s\n", buffer);
> > +             goto fail1;
> > +     }
> > +
> > +     snprintf(buffer, 20, "%s err", up->name);
> > +     retval = request_irq(up->err_irq, sport_uart_err_irq, IRQF_SAMPLE_RANDOM, buffer, up);
> > +     if (retval) {
> > +             printk(KERN_ERR "Unable to request interrupt %s\n", buffer);
> > +             goto fail2;
> > +     }
>
> It is not a good idea to create files in /proc which have spaces in their
> names.  Yes, userspace _should_ be able to cope with that in all cases, but
> all software sucks, even including userspace ;)
>
> I'd suggest that we be defensive here, and avoid using spaces in filenames.

i'm not sure i follow ... these are the names given to request_irq()
which means this is what shows up in /proc/interrupts ... does this
function also create an actual file somewhere in /proc that i am not
aware of ?

the rest of the comments look good to me, thanks !
-mike
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/