RE: [PATCH 2.6.23]ata_piix: SATA 2port controller port map fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>this was full of spaces, and should be converted to tabs (I did this
>manually)
>
>In the future, make sure to run your patch through
>scripts/checkpatch.pl.  Some of that script's complaints are a bit
>insane, but most are good.
>
>>  static const struct piix_map_db *piix_map_db_table[] = {
>>  	[ich5_sata]		= &ich5_map_db,
>>  	[ich6_sata]		= &ich6_map_db,
>> @@ -463,6 +476,7 @@
>>  	[ich6m_sata_ahci]	= &ich6m_map_db,
>>  	[ich8_sata_ahci]	= &ich8_map_db,
>>  	[tolapai_sata_ahci]	= &tolapai_map_db,
>> +	[ich9_2port_sata]	= &ich9_2port_map_db,
>>  };
>>
>>  static struct ata_port_info piix_port_info[] = {
>> @@ -587,6 +601,17 @@
>>  		.udma_mask	= ATA_UDMA6,
>>  		.port_ops	= &piix_sata_ops,
>>  	},
>> +
>> +	/* ich9_2port_sata: 12: */
>
>changed this to
>
>	[ich9_2port_sata] =
>
>since we have started using the (C99? gcc?) method of initializing
>piix_port_info[] array entries based on the given index, rather than
>simply noting the index in a comment and depending on the order of
other
>entries not to change.
>
>	Jeff

Thank you Jeff!  I guess it is time to switch email clients, as this one
keeps trashing my file import.  I thought I had it worked out, guess
not.  

Thanks again,

Jason
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux