Re: [build bug] error: 'VID_HARDWARE_GEMTEK' undeclared

[Mauro Carvalho Chehab <mchehab@infradead.org>]

Em Seg, 2007-10-15 às 11:27 -0700, Trent Piepho escreveu:
> On Mon, 15 Oct 2007, Ingo Molnar wrote:
> > randconfig testing of latest -git found this build bug:
> >
> > drivers/media/radio/radio-gemtek.c:557: error: 'VID_HARDWARE_GEMTEK' undeclared here (not in a function)
> >
> > config attached.
> 
> Problem:
> # CONFIG_VIDEO_V4L1_COMPAT is not set
> 
> The VID_HARDWARE_* defines are only created if that is turned on.  gemtek
> should depend on VIDEO_V4L1_COMPAT.
> 
> *or*
> 
> As far as I can tell, these VID_HARDWARE defines are entirely useless.  I
> couldn't find any instance of them being used for anything other than setting
> the .hardware field of struct video_device, and I was unable to find any
> instance of that field being used.
> 
> It looks like the whole thing is just unused cruft.  Mauro, would it be ok if
> I made a patch to just delete the whole mess?

Those VID_HARDWARE_* are bogus. No place checks for the .hardware value.
I've already made a patch removing it. Feel free to double check it.

-- 
Cheers,
Mauro

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/