Hi Geert,
On 10/13/07, Geert Uytterhoeven <[email protected]> wrote:
> m68k: Atari input drivers cleanup:
> - memleak on failed init/register of input devices fixed
> - correct keycodes table (Atari keycodes are almost, but not entirely, equal
> to Linux keycodes).
>
> Signed-off-by: Michael Schmitz <[email protected]>
> Signed-off-by: Geert Uytterhoeven <[email protected]>
Looks much better, thank you.
>
> - input_register_device(atakbd_dev);
> + /* error check */
> + if (input_register_device(atakbd_dev)) {
> + input_free_device(atakbd_dev);
> + return -ENOMEM;
> + }
>
I'd be more happy if we returned real error reported by
input_register_device() instead of substituting it with -ENOMEM.
--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
