Re: [PATCH] fw-cdev __user annotations

[Stefan Richter <stefanr@s5r6.in-berlin.de>]

Al Viro wrote:
> --- a/drivers/firewire/fw-cdev.c
> +++ b/drivers/firewire/fw-cdev.c
> @@ -722,10 +722,11 @@ static int ioctl_queue_iso(struct client *client, void *buffer)
>  		buffer_end = 0;
>  	}
>  
> -	if (!access_ok(VERIFY_READ, request->packets, request->size))
> +	p = (struct fw_cdev_iso_packet __user *)u64_to_uptr(request->packets);
> +
> +	if (!access_ok(VERIFY_READ, p, request->size))
>  		return -EFAULT;
>  
> -	p = (struct fw_cdev_iso_packet __user *)u64_to_uptr(request->packets);
>  	end = (void __user *)p + request->size;
>  	count = 0;
>  	while (p < end) {

Acked-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

I will enqueue it in case Linus doesn't pick it up before my next pull
request.
-- 
Stefan Richter
-=====-=-=== =-=- -===-
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/