tuner-core.c:fe_has_signal() can returne uninitialized value

Commit 1f5ef19779df2c2f75870332b37dd3004c08a515 added the following 
function to drivers/media/video/tuner-core.c:

<--  snip  -->

static int fe_has_signal(struct tuner *t)
{
        struct dvb_tuner_ops *fe_tuner_ops = &t->fe.ops.tuner_ops;
        u16 strength;

        if (fe_tuner_ops->get_rf_strength)
                fe_tuner_ops->get_rf_strength(&t->fe, &strength);

        return strength;
}

<--  snip  -->


If (!fe_tuner_ops->get_rf_strength) this function returns the value of 
an uninitialized variable.

Spotted by the Coverity checker.


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: tuner-core.c:fe_has_signal() can returne uninitialized value
    • From: Michael Krufky <[email protected]>

• Prev by Date: b43{,legacy}_start can return uninitialized value
• Next by Date: [2.6 patch] __inet6_csk_dst_store(): fix check-after-use
• Previous by thread: b43{,legacy}_start can return uninitialized value
• Next by thread: Re: tuner-core.c:fe_has_signal() can returne uninitialized value
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]