[PATCH] mmc: possible leak in mmc_read_ext_csd

The exception path associated with an invalid ext_csd_struct returns without freeing ext_csd.

Coverity CID 1909.

Signed-off-by: Florin Malita
---

drivers/mmc/core/mmc.c |    3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index 65fe288..68c0e3b 100644
--- a/drivers/mmc/core/mmc.c
+++ b/drivers/mmc/core/mmc.c
@@ -213,7 +213,8 @@ static int mmc_read_ext_csd(struct mmc_card *card)
		printk(KERN_ERR "%s: unrecognised EXT_CSD structure "
			"version %d\n", mmc_hostname(card->host),
			ext_csd_struct);
-		return -EINVAL;
+		err = -EINVAL;
+		goto out;
	}

	if (ext_csd_struct >= 2) {

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] mmc: possible leak in mmc_read_ext_csd
    • From: Pierre Ossman <[email protected]>

• Prev by Date: [git patches] IDE updates (part 2)
• Next by Date: Re: [PATCH] Allow kconfig to accept overrides
• Previous by thread: [git patches] IDE updates (part 2)
• Next by thread: Re: [PATCH] mmc: possible leak in mmc_read_ext_csd
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]