Re: [PATCH 2/2] powerpc: Switch to generic WARN_ON()/BUG_ON()

On Fri, Oct 12, 2007 at 11:23:39AM +1000, Paul Mackerras wrote:
> Olof Johansson writes:
> 
> > Not using the ppc-specific WARN_ON/BUG_ON constructs actually saves about
> > 4K text on a ppc64_defconfig. The main reason seems to be that prepping
> > the arguments to the conditional trap instructions is more work than
> > just doing a compare and branch.
> 
> It might be more instructions but it takes fewer cycles, I would
> expect.  Do you have the actual instruction sequences to compare?
> 

I really hope WARN_ON/BUG_ON aren't hotpaths on powerpc. ;-)

Cheers,
	Kyle
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 2/2] powerpc: Switch to generic WARN_ON()/BUG_ON()
    • From: Olof Johansson <[email protected]>

• References:
  • [PATCH 1/2] bug.h: Introduce HAVE_ARCH_WARN
    • From: Olof Johansson <[email protected]>
  • [PATCH 2/2] powerpc: Switch to generic WARN_ON()/BUG_ON()
    • From: Olof Johansson <[email protected]>
  • Re: [PATCH 2/2] powerpc: Switch to generic WARN_ON()/BUG_ON()
    • From: Paul Mackerras <[email protected]>

• Prev by Date: Re: Linux 2.6.23
• Next by Date: 2.6.23-rt1
• Previous by thread: Re: [PATCH 2/2] powerpc: Switch to generic WARN_ON()/BUG_ON()
• Next by thread: Re: [PATCH 2/2] powerpc: Switch to generic WARN_ON()/BUG_ON()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]