Re: [RFC][PATCH 4/7] make open_namei() return a filp

> If open_namei() succeeds, there is potentially a mnt_want_write()
> that needs to get balanced.  If the caller doesn't create a
> 'struct file' and eventually __fput() it, or manually drop the
> write count on an error, we have a bug.
> 
> Forcing open_namei() to return a filp fixes this.  Any caller
> getting a 'struct file' back must consider that filp instantiated
> and fput() it normally.  The callers no longer have to worry about
> ever manually releasing a mnt write count.

I think this changelog is out of date, as this problem should have
been dealt with in patch-2/7.

Otherwise I don't object to this change, it looks like a fine cleanup.

Miklos
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [RFC][PATCH 1/7] init_file(): only take writes on normal files
    • From: Dave Hansen <[email protected]>
  • [RFC][PATCH 4/7] make open_namei() return a filp
    • From: Dave Hansen <[email protected]>

• Prev by Date: Re: [PATCH] init: Fix printk format strings
• Next by Date: Re: fix minor problems in checkpatch.pl-next
• Previous by thread: [RFC][PATCH 4/7] make open_namei() return a filp
• Next by thread: [RFC][PATCH 6/7] kill filp_open()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]