Re: [PATCH] RT: fix spin_trylock_irq

[Steven Rostedt <rostedt@goodmis.org>]

--
When I'm asked what language is my mother tongue,
I simply answer "C".

On Thu, 11 Oct 2007, [UTF-8] Sébastien Dugué wrote:

> ---
>  include/linux/spinlock.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6.23-rc9-rt2/include/linux/spinlock.h
> ===================================================================
> --- linux-2.6.23-rc9-rt2.orig/include/linux/spinlock.h
> +++ linux-2.6.23-rc9-rt2/include/linux/spinlock.h
> @@ -501,7 +501,7 @@ do {									\
>
>  #define spin_trylock_irq(lock)	\
>  	__cond_lock(lock, PICK_SPIN_OP_RET(__spin_trylock_irq,		\
> -		__spin_trylock_irq, lock))
> +		_spin_trylock_irq, lock))
>
>  #define spin_trylock_irqsave(lock, flags) \
>  	__cond_lock(lock, PICK_SPIN_OP_RET(__spin_trylock_irqsave, 	\

Thanks! Applied.

Daniel, this BUG was introduced by your conversion to PICK_FUNCTION patch.
Please be more careful, and do an audit of your patch. (I don't have time
ATM). This could also be the source of other bugs I've been chasing.

I might be pulling the PICK_FUNCTION patches if there's more bugs like
this.

-- Steve

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/