Re: [PATCH] Make m68k cross compile like every other architecture.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 11, 2007 at 08:27:12AM -0500, Rob Landley wrote:
> On Thursday 11 October 2007 7:46:47 am Geert Uytterhoeven wrote:
> > On Thu, 11 Oct 2007, Sam Ravnborg wrote:
> > > On Thu, Oct 11, 2007 at 09:25:19AM +0200, Geert Uytterhoeven wrote:
> > > > BTW, m68k-linux-gnu- is the default name for a m68k cross compiler.
> > >
> > > For "make headers_install" this is not good.
> > > But I see there is confliting usages here.
> > > 1) current functionality makes it easy to build a cross compiled m68k
> > >
> > > Btw. if you did:
> > > CROSS_COMPILE ?= m68k-linux-
> > >
> > > then I could do:
> > > export CROSS_COMPILE=my-m68k-linux-
> > > make
> > >
> > > and still get the expected result.
> >
> > That won't work, cfr. http://lkml.org/lkml/2007/5/6/58.
> 
> Reading the patch in that link, recent cross compilers from _where_?  
> Buildroot?  Cross-tools?  Gentoo embedded?  Cross Linux From Scratch?  My 
> Firmware Linux project?
> 
> You assume they all use the same name, yet your patch changes them from one 
> default name to another default name, presumably due to a gcc version change 
> becoming increasingly political about the GNU/Linux/Dammit thing...
> 
> None of the other targets I've tried attempt to _supply_ a default.  Just like 
> the Linux kernel errors out early in the build if you distclean and then try 
> to run "make" without having run config first.  It doesn't run "defconfig" 
> for you and continue on in that case.  But m68k, uniquely, assumes it knows 
> what you want to do when you didn't tell it.  Other targets do not do this.
> 
Many platforms used to do this. For most of them it didn't end up being
useful given all of the target variant, so they just got removed. If
that's not the case for m68k and it's still useful for people there, then
there's no reason to remove it. If you want to overload it you are free
to, but Geert is right that headers_install shouldn't be calling the
cross compiler if it has no dependency on it. Fixing bugs is preferable
to fixing symptoms.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux