Re: [PATCH] [RESEND] i386 and x86_64: randomize brk()

[Jiri Kosina <jkosina@suse.cz>]

On Thu, 11 Oct 2007, Andrew Morton wrote:

> I seem to have a different copy of this patch from the one which you 
> originally sent.  It's the one which implements arch_randomize_brk() in 
> each arch's header file.  Mayeb it wasn't cc'ed to a mailing list of 
> maybe I just lost the email, dunno.

Yes, it should the the last version of this patch, and it should also have 
gone to lkml.

> Anyway, it breaks on ia64:
[...]
> This is because ia64 takes the exceptional stupidity which is our
> elf-handling build system and adds an extra layer of stupidity on top of
> it.  Look:
> akpm2:/usr/src/25> grep -r _ASM_IA64_ELF_H arch/ia64
> arch/ia64/ia32/ia32priv.h:#define _ASM_IA64_ELF_H               /* Don't include elf.h */
> can you believe this stuff?

Oh, that's pretty crazy indeed. Including of binfmt_elf.c from all over 
the place is crazy as hell by itself, but this certainly adds a lot of 
additional mess. 

> Wanna see if there's something saner we can do please?

Apart from rewriting the whole thing to make more sense, I don't see 
currently a way out of it better than your patch :(

-- 
Jiri Kosina
SUSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/