Hi Olof, On Tue, 9 Oct 2007 19:08:15 -0500 Olof Johansson <[email protected]> wrote: > > Don't allow cpu hotplug on systems lacking XICS interrupt controller, > since current platform code is hardcoded for it. > > > Signed-off-by: Olof Johansson <[email protected]> > > > diff --git a/arch/powerpc/platforms/pseries/hotplug-cpu.c b/arch/powerpc/platforms/pseries/hotplug-cpu.c > index 9711eb0..e29b890 100644 > --- a/arch/powerpc/platforms/pseries/hotplug-cpu.c > +++ b/arch/powerpc/platforms/pseries/hotplug-cpu.c > @@ -252,6 +252,19 @@ static struct notifier_block pseries_smp_nb = { > > static int __init pseries_cpu_hotplug_init(void) > { > + struct device_node *np; > + const char *typep; > + > + for (np = NULL; (np = of_find_node_by_name(np, > + "interrupt-controller"));) { > + typep = of_get_property(np, "compatible", NULL); > + if (strstr(typep, "open-pic")) { > + printk(KERN_INFO "CPU Hotplug not supported on " > + "systems using MPIC\n"); You need an of_node_put(np) here. -- Cheers, Stephen Rothwell [email protected] http://www.canb.auug.org.au/~sfr/
Attachment:
pgpfCkgTZe1ww.pgp
Description: PGP signature
- Follow-Ups:
- [PATCH v2] powerpc: don't enable cpu hotplug on mpic-based pseries
- From: Olof Johansson <[email protected]>
- [PATCH v2] powerpc: don't enable cpu hotplug on mpic-based pseries
- References:
- [patch 09/12] Fix SMP poweroff hangs
- From: Greg KH <[email protected]>
- Re: [patch 09/12] Fix SMP poweroff hangs
- From: Olof Johansson <[email protected]>
- Re: [stable] [patch 09/12] Fix SMP poweroff hangs
- From: Greg KH <[email protected]>
- Re: [stable] [patch 09/12] Fix SMP poweroff hangs
- From: Thomas Gleixner <[email protected]>
- Re: [stable] [patch 09/12] Fix SMP poweroff hangs
- From: Linus Torvalds <[email protected]>
- [PATCH] powerpc: don't enable cpu hotplug on mpic-based pseries
- From: Olof Johansson <[email protected]>
- [patch 09/12] Fix SMP poweroff hangs
- Prev by Date: Re: [PATCH 1/3] V4L: w9968cf, remove bad usage of ERESTARTSYS
- Next by Date: Re: [PATCH 2/3] V4L: zc0301, remove bad usage of ERESTARTSYS
- Previous by thread: [PATCH] powerpc: don't enable cpu hotplug on mpic-based pseries
- Next by thread: [PATCH v2] powerpc: don't enable cpu hotplug on mpic-based pseries
- Index(es):
 |