From: David Brownell <[email protected]>
Date: Tue, 09 Oct 2007 09:38:27 -0700
> > > What values do you see for "portstat"?
> >
> > 0x111
>
> That's unfortunately useless ... PPS, PRS, CCS (meaning powered,
> resetting, connected). In short, there is *no* indication from
> the OHCI hardware that a disconnect happened.
But it's an excellent example of why my patch is mandatory.
When the device gets into a stuck state, this code does the wrong
thing.
Instead of trying to deal with bad situations, it hangs the system
instead. That sucks for anyone trying to debug something like this.
This has caused weeks of debugging and grief for people, and it
could have all been eliminated if this looping code were more
robust to hardware failures.
If you can't see why this is bad programming practice in a hardware
driver, I will try to get my patch to someone who does.
Even though I'm severly overloaded, you asked me for a patch, I gave
you one. And now you want to push it back at me because it isn't
clear to you yet that the code there right now is a huge problem.
And all of this is independant of making sure EHCI loads first,
we need to fix that too.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
