Re: [PATCH v4] IBM power meter driver

On Tue, Oct 09, 2007 at 06:44:07PM +0200, Roel Kluin wrote:

> >> +	if (IS_ERR(data->hwmon_dev)) {
> >> +		printk(KERN_ERR DRVNAME ": Error, unable to register hwmon "
> >> +		       "class device for interface %d\n",
> >> +		       data->interface);
> >> +		kfree(data);
> >> +		return;
> 
> don't you want to goto out_user here instead?

Err, yes, thank you for catching that.

--D
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Re: [PATCH v4] IBM power meter driver
    • From: "Mark M. Hoffman" <[email protected]>
  • Re: [PATCH v4] IBM power meter driver
    • From: Roel Kluin <[email protected]>

• Prev by Date: Re: [RFC PATCH RT] push waiting rt tasks to cpus with lower prios.
• Next by Date: [RFC] [Patch] calgary iommu: Use the first kernel's tce tables in kdump
• Previous by thread: Re: [PATCH v4] IBM power meter driver
• Next by thread: [PATCH] ibmpex: Release IPMI user if hwmon registration fails
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]