Re: [PATCH] Stop docproc segfaulting when SRCTREE isn't set.

Hi Rob,

On Tue, Oct 09, 2007 at 01:25:18AM -0500, Rob Landley wrote:
[...]
>  	FILE * infile;
> +
> +	srctree = getenv("SRCTREE");
> +	if (!srctree) srctree = getcwd(NULL,0);
>  	if (argc != 3) {
>  		usage();
>  		exit(1);

$ man getcwd

 char *getcwd(char *buf, size_t size);
      
 As an extension to the POSIX.1 standard, Linux (libc4, libc5, glibc) getcwd() 
 allocates the buffer dynamically using malloc() if buf is NULL on call.

Shouldn't "srctree" be free()ed in case getenv("SRCTREE") failed ?

Regards,

-- 
Ahmed S. Darwish
HomePage: http://darwish.07.googlepages.com
Blog: http://darwish-07.blogspot.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Stop docproc segfaulting when SRCTREE isn't set.
    • From: Rob Landley <[email protected]>
  • Re: [PATCH] Stop docproc segfaulting when SRCTREE isn't set.
    • From: Randy Dunlap <[email protected]>

• References:
  • [PATCH] Stop docproc segfaulting when SRCTREE isn't set.
    • From: Rob Landley <[email protected]>

• Prev by Date: [PATCH 0/2] i386: MCE updates
• Next by Date: Re: 2.6.22.6: kernel BUG at fs/locks.c:171
• Previous by thread: [PATCH] Stop docproc segfaulting when SRCTREE isn't set.
• Next by thread: Re: [PATCH] Stop docproc segfaulting when SRCTREE isn't set.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]