> if (unlikely(down_trylock(&port->tty_sem))) {
> /*
> * must test lock as tty layer wraps calls
> * to this function with BKL
> */
> dev_err(&dc->pdev->dev, "Would have deadlocked - "
> "return ERESTARTSYS\n");
> return -ERESTARTSYS;
> }
>
> The use of ERESTARTSYS seems bogus to me, no signal is pending and this flag
> would reach userspace (that is not permitted), am I right?
serial driver write methods are called from the ldisc not the tty so the
code is in fact totally bogus.
I suspect what is needed (other than to take the entire driver to bits
and put it back together using serial_core) is
if (down_trylock(&port->tty_sem))
return 0;
and the driver is then required to wake the write wait queue when that
condition becomes false - or at least before/when it runs out of
data (which currently it doesn't seem to for all cases).
Lots of other breakage in it as well (termios function is totally bogus,
tty_flip_queue_function is a no-op) etc etc
Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
