Re: [PATCH 3/5] forcedeth: process TX completions using NAPI

Jeff Garzik wrote:

commit 57cbfacc00d69be2ba02b65d1021442273b76263
Author: Jeff Garzik <[email protected]>
Date:   Fri Oct 5 23:25:56 2007 -0400

    [netdrvr] forcedeth: process TX completions using NAPI

Signed-off-by: Jeff Garzik <[email protected]>

 drivers/net/forcedeth.c |  143 +++++++++++++++++++++++++++---------------------
 1 file changed, 83 insertions(+), 60 deletions(-)

The attached patch fixes an obvious bug. Once applied, TX NAPI actually works :)

diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
index 1c236e6..e25c05e 100644
--- a/drivers/net/forcedeth.c
+++ b/drivers/net/forcedeth.c
@@ -3059,7 +3059,7 @@ static irqreturn_t nv_nic_irq_tx(int foo, void *data)
 
 static int nv_napi_tx_poll(struct napi_struct *napi, int budget)
 {
-	struct fe_priv *np = container_of(napi, struct fe_priv, napi);
+	struct fe_priv *np = container_of(napi, struct fe_priv, tx_napi);
 	struct net_device *dev = np->dev;
 	u8 __iomem *base = get_hwbase(dev);
 	unsigned long flags;

---

• References:
  • [PATCH 0/5] forcedeth: several proposed updates for testing
    • From: Jeff Garzik <[email protected]>
  • [PATCH 3/5] forcedeth: process TX completions using NAPI
    • From: Jeff Garzik <[email protected]>

• Prev by Date: Re: sata_sil24 broken since 2.6.23-rc4-mm1
• Next by Date: Re: [PATCH 6/n] forcedeth: protect slow path with mutex
• Previous by thread: [PATCH 3/5] forcedeth: process TX completions using NAPI
• Next by thread: [PATCH 4/5] forcedeth: internal simplification and cleanups
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]