Re: [patch 1/9] compat_ioctl: move common block ioctls to compat_blkdev_ioctl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Saturday 06 October 2007, Christoph Hellwig wrote:
> > +static int compat_put_u64(unsigned long arg, u64 val)
> > +{
> > +     return put_user(val, (compat_u64 __user *)compat_ptr(arg));
> > +}
> 
> These should probably be in compat.h

Hmm, I'm not sure. They are modeled after the put_{short,int,uint,...}
functions that only exist in block/ioctl.c and I put them in so I
could use almost identical code in the native and compat path.

If we find these generally useful, I guess we could have both
versions of each of these functions in global headers, e.g. in
linux/uaccess.h and linux/compat.h, but right now I would recommend
using plain put_user in all compat code except for block ioctl.

	Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux