Re: [PATCH] GEODE: decouple sleep/resume from powerdown/powerup

Hi!

> This patch merges the fb_powerup and fb_powerdown hooks in a single
> operation fb_power with an additional "state" parameter ranging
> from 0 (running) to 3 (poweroff).

No, please don't. Having int with 0/3 being valid specifying what to
do is evil.

enum is less evil, but what's wrong about having 3 functions?

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH] GEODE: decouple sleep/resume from powerdown/powerup
  - From: Bernardo Innocenti <[email protected]>

Prev by Date: [PATCH] Replace __attribute_pure__ with __pure
Next by Date: Re: race with page_referenced_one->ptep_test_and_clear_young and pagetable setup/pulldown
Previous by thread: [PATCH] Replace __attribute_pure__ with __pure
Next by thread: Re: [PATCH] GEODE: decouple sleep/resume from powerdown/powerup
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]