Re: [PATCH] isofs: add +w bit for non-RR discs

[Jan Engelhardt <jengelh@computergmbh.de>]

On Oct 4 2007 20:46, Matthew Wilcox wrote:
>On Tue, Oct 02, 2007 at 08:00:26PM +0200, Jan Engelhardt wrote:
>> Add %S_IWUGO bit for files on ISO-9660 filesystems without RockRidge
>
>Looks to me like you've added S_IWUSR, not S_IWUGO.

Yes, S_IWUSR it should be, and is. When a user copies such a file,
the new file will be owned by him/her, so the +w bit needs to
be S_IWUSR indeed.

>> -	popt->mode = S_IRUGO | S_IXUGO; /*
>> +	popt->mode = S_IRUGO | S_IWUSR | S_IXUGO;
>> -		inode->i_mode = S_IRUGO | S_IXUGO | S_IFDIR;
>> +		inode->i_mode = S_IRUGO | S_IWUSR | S_IXUGO | S_IFDIR;
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/