Hi,
On Thu, 20 Sep 2007, Shlomi Fish wrote:
> Which specific problems do you see with the coding style of the patch? Can you
> comment on it?
Mostly whitespace around any braces, please keep it close to the other
source.
> > I would also prefer to move more of the search functionality into the
> > generic code, so it can be used by other front ends as well, otherwise a
> > lot of this had to be duplicated.
>
> That would be a good idea, but I cannot use Qt there, which makes my job
> harder.
Where is the problem with implementing it in C? Just try to keep it a
simple at first.
> > I think a filter function makes it maybe a bit to flexible, if a front
> > end wants to do some weird filtering, it can still access the symbol
> > data base directly.
>
> A filter function would still be convenient in this context, as the symbol
> data base API may change, and the filter function has a little logic in it.
This API is not really fixed at the moment, so it's not really a problem.
> > So what I have in mind is something like this:
> >
> > struct symbol **sym_generic_search(const char *pattern, unsigned int
> > flags);
> >
> > This means the back end provides a basic search facility for the most
> > common search operations. The flags would specify what to search (e.g.
> > symbol name, help text, prompts) and how to do it.
>
> I suggest we don't call it sym_generic_search, as generic implies it is a
> generic filter. We can call it "sym_string_search" or whatever. Then, I
> suggest we have separate arguments for every parameter (i.e: search type,
> case sensitivity, what to search, etc.).
I don't care much about the name, but please keep it as a simple flag,
which is a lot easier to extend.
bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
