Re: [NFS] What's slated for inclusion in 2.6.24-rc1 from the NFS client git tree...

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Trond Myklebust wrote:
On Thu, 2007-10-04 at 11:42 -0700, Andrew Morton wrote:
On Thu, 4 Oct 2007 18:43:04 +0200
Pierre Ossman <[email protected]> wrote:

On Thu, 04 Oct 2007 10:00:50 -0400
Trond Myklebust <[email protected]> wrote:

On Thu, 2007-10-04 at 08:52 +0200, Pierre Ossman wrote:
On Wed, 03 Oct 2007 19:41:16 -0400
Trond Myklebust <[email protected]> wrote:

We also have the 64-bit inode support from RedHat/Peter Staubach.

As has been pointed[1] out[2], this will cause regressions for
non-LFS applications (of which there are still lots and lots). This
change should be in feature-removal (the "feature" being removed is
legacy support for non-LFS applications using NFS servers that make
full use of the protocol) and preferably accompanied with
appropriate user space changes (e.g. compatibility option in glibc).

[1] https://bugzilla.redhat.com/show_bug.cgi?id=241348
[2] http://marc.info/?l=linux-nfs&m=118701088726477&w=2

Rgds
How about a boot/module parameter to turn it on or off?

That would be perfect. It can even be in non-legacy mode by default,
just as long as you can go back to the old behaviour when/if you run
into a non-LFS application.

Wouldn't a mount option be better?

I suppose that might be OK if you know that the 32-bit legacy
applications will only touch one or two servers, but that sounds like a
niche thing.

On the downside, forcing all those people who have portable 64-bit aware
applications to upgrade their version of mount just in order to have
stat64() work correctly seems unnecessarily complicated. I'd prefer not
to have to do that unless someone comes up with a good reason why we
must.

I would agree.  The 64 bit fileids will only become visible when
the server is exporting file systems which contain fileids which
are bigger than 32 bits and then only when the application
encounters these files.

Also, these 32-bit legacy applications are going to have a
problem if they are ever run on a system which contains local
file systems which expose the large fileids.

It would be better to identify these applications and get them
fixed.  The world is evolving and it is time for them to do so.

      ps
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux