[PATCH] ext4: Convert bg_block_bitmap to bg_block_bitmap_lo

From: Aneesh Kumar K.V <[email protected]>

Convert bg_block_bitmap to bg_block_bitmap_lo
This helps in catching some BUGS due to direct
partial access of these split fields.

Signed-off-by: Aneesh Kumar K.V <[email protected]>
---
 fs/ext4/super.c         |    6 +++---
 include/linux/ext4_fs.h |    2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index d8bb279..02a2418 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -70,9 +70,9 @@ static void ext4_write_super_lockfs(struct super_block *sb);
 ext4_fsblk_t ext4_block_bitmap(struct super_block *sb,
 			       struct ext4_group_desc *bg)
 {
-	return le32_to_cpu(bg->bg_block_bitmap) |
+	return le32_to_cpu(bg->bg_block_bitmap_lo) |
 		(EXT4_DESC_SIZE(sb) >= EXT4_MIN_DESC_SIZE_64BIT ?
-		 (ext4_fsblk_t)le32_to_cpu(bg->bg_block_bitmap_hi) << 32 : 0);
+		(ext4_fsblk_t)le32_to_cpu(bg->bg_block_bitmap_hi) << 32 : 0);
 }
 
 ext4_fsblk_t ext4_inode_bitmap(struct super_block *sb,
@@ -94,7 +94,7 @@ ext4_fsblk_t ext4_inode_table(struct super_block *sb,
 void ext4_block_bitmap_set(struct super_block *sb,
 			   struct ext4_group_desc *bg, ext4_fsblk_t blk)
 {
-	bg->bg_block_bitmap = cpu_to_le32((u32)blk);
+	bg->bg_block_bitmap_lo = cpu_to_le32((u32)blk);
 	if (EXT4_DESC_SIZE(sb) >= EXT4_MIN_DESC_SIZE_64BIT)
 		bg->bg_block_bitmap_hi = cpu_to_le32(blk >> 32);
 }
diff --git a/include/linux/ext4_fs.h b/include/linux/ext4_fs.h
index ab608e8..c26e30e 100644
--- a/include/linux/ext4_fs.h
+++ b/include/linux/ext4_fs.h
@@ -105,7 +105,7 @@
  */
 struct ext4_group_desc
 {
-	__le32	bg_block_bitmap;	/* Blocks bitmap block */
+	__le32	bg_block_bitmap_lo;	/* Blocks bitmap block */
 	__le32	bg_inode_bitmap;	/* Inodes bitmap block */
 	__le32	bg_inode_table;		/* Inodes table block */
 	__le16	bg_free_blocks_count;	/* Free blocks count */
-- 
1.5.3.2.81.g17ed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • [PATCH] ext4: Convert bg_inode_bitmap and bg_inode_table
    • From: "Theodore Ts'o" <[email protected]>

• References:
  • [PATCH, RFC] Ext4 patches planned for submission upstream
    • From: "Theodore Ts'o" <[email protected]>
  • [PATCH] jbd/jbd2: JBD memory allocation cleanups
    • From: "Theodore Ts'o" <[email protected]>
  • [PATCH] jbd/jbd2: Journal initialization doesn't need __GFP_NOFAIL
    • From: "Theodore Ts'o" <[email protected]>
  • [PATCH] JBD2/Ext4: Convert kmalloc to kzalloc in jbd2/ext4
    • From: "Theodore Ts'o" <[email protected]>
  • [PATCH] jbd2: fix commit code to properly abort journal
    • From: "Theodore Ts'o" <[email protected]>
  • [PATCH] JBD2: debug code cleanup.
    • From: "Theodore Ts'o" <[email protected]>
  • [PATCH] Once ext4 will not implement fragment, it is believed it will never be
    • From: "Theodore Ts'o" <[email protected]>
  • [PATCH] ext4: remove #ifdef CONFIG_EXT4_INDEX
    • From: "Theodore Ts'o" <[email protected]>
  • [PATCH] Ext4: Uninitialized Block Groups
    • From: "Theodore Ts'o" <[email protected]>
  • [PATCH] ext4: Fix sparse warnings
    • From: "Theodore Ts'o" <[email protected]>
  • [PATCH] This feature relaxes check restrictions on where each block groups meta
    • From: "Theodore Ts'o" <[email protected]>
  • [PATCH] Support large blocksize up to PAGESIZE (max 64KB) for ext4
    • From: "Theodore Ts'o" <[email protected]>
  • [PATCH] ext4: Avoid rec_len overflow with 64KB block size
    • From: "Theodore Ts'o" <[email protected]>
  • [PATCH] Support large blocksize up to PAGESIZE (max 64KB) for ext2
    • From: "Theodore Ts'o" <[email protected]>
  • [PATCH] Support large blocksize up to PAGESIZE (max 64KB) for ext3
    • From: "Theodore Ts'o" <[email protected]>
  • [PATCH] ext2: Avoid rec_len overflow with 64KB block size
    • From: "Theodore Ts'o" <[email protected]>
  • [PATCH] ext3: Avoid rec_len overflow with 64KB block size
    • From: "Theodore Ts'o" <[email protected]>

• Prev by Date: [PATCH] ext4: Convert s_r_blocks_count and s_free_blocks_count
• Next by Date: [PATCH] ext4: Convert ext4_extent.ee_start to ext4_extent.ee_start_lo
• Previous by thread: [PATCH] ext3: Avoid rec_len overflow with 64KB block size
• Next by thread: [PATCH] ext4: Convert bg_inode_bitmap and bg_inode_table
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]