Re: MSI: Use correct data offset for 32-bit MSI in read_msi_msg()

Roland Dreier <[email protected]> writes:

>  > > While reading the MSI code trying to find a reason why MSI wouldn't
>  > > work for devices that have a 32-bit MSI address capability, I noticed
>  > > that read_msi_msg() seems to read the message data from the wrong
>  > > offset in this case.
>  > 
>  > Doh!  Sorry about that.
>
> Doesn't matter, it wasn't the bug hitting me anyway :) the IRQ never
> got affinity changed so read_msi_msg() never even got called.
>
> I'm starting to think that Intel 945GM graphics just has a busted MSI
> implementation, although there may be a bug hiding in the Linux code
> that I'm not seeing.

Well it is a bug worth fixing.  Who knows it may have something
to do with the disable_irq problems the forcedeth driver was seeing.

Right now MSI is still sufficiently new that everyone is still getting
the bugs out of their implementations.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: MSI: Use correct data offset for 32-bit MSI in read_msi_msg()
    • From: Roland Dreier <[email protected]>

• References:
  • Re: MSI: Use correct data offset for 32-bit MSI in read_msi_msg()
    • From: [email protected] (Eric W. Biederman)
  • Re: MSI: Use correct data offset for 32-bit MSI in read_msi_msg()
    • From: Roland Dreier <[email protected]>

• Prev by Date: [PATCH][RFC] unbreak generic futex_atomic_cmpxchg_inatomic() on UP
• Next by Date: Re: MSI: Use correct data offset for 32-bit MSI in read_msi_msg()
• Previous by thread: Re: MSI: Use correct data offset for 32-bit MSI in read_msi_msg()
• Next by thread: Re: MSI: Use correct data offset for 32-bit MSI in read_msi_msg()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]