On tis, 2007-10-02 at 18:02 -0700, Stephen Hemminger wrote: > Remove unneeded check that caused problems with jumbo frame sizes. > The check was recently added and is wrong. > When using jumbo frames the sky2 driver does fragmentation, so > rx_data_size is less than mtu. Confirmed working. Now running with 9k mtu with no errors, =) It also seems that the FIFO bug was the one that affected me before, damn odd race that one. > Signed-off-by: Stephen Hemminger <[email protected]> Tested-by: Ian Kumlien <[email protected]> (if that tag exists now) Btw, Sorry but all mail directly to you will be blocked. I have yet to fix the relaying properly with isp:s blocking port 25 etc so for some of you this mail will only show up on the ML. > --- a/drivers/net/sky2.c 2007-10-02 17:56:31.000000000 -0700 > +++ b/drivers/net/sky2.c 2007-10-02 17:58:56.000000000 -0700 > @@ -2163,9 +2163,6 @@ static struct sk_buff *sky2_receive(stru > sky2->rx_next = (sky2->rx_next + 1) % sky2->rx_pending; > prefetch(sky2->rx_ring + sky2->rx_next); > > - if (length < ETH_ZLEN || length > sky2->rx_data_size) > - goto len_error; > - > /* This chip has hardware problems that generates bogus status. > * So do only marginal checking and expect higher level protocols > * to handle crap frames. -- Ian Kumlien <pomac () vapor ! com> -- http://pomac.netswarm.net
Attachment:
signature.asc
Description: This is a digitally signed message part
- Follow-Ups:
- Re: [PATCH] sky2: jumbo frame regression fix
- From: Bill Davidsen <[email protected]>
- Re: [PATCH] sky2: jumbo frame regression fix
- From: Stephen Hemminger <[email protected]>
- Re: [PATCH] sky2: jumbo frame regression fix
- References:
- [BUG] sky2 errors in 2.6.23-rc9-git1
- From: Ian Kumlien <[email protected]>
- [PATCH] sky2: jumbo frame regression fix
- From: Stephen Hemminger <[email protected]>
- [BUG] sky2 errors in 2.6.23-rc9-git1
- Prev by Date: Re: [PATCH 5/5] writeback: introduce writeback_control.more_io to indicate more io
- Next by Date: [PATCH] libata: fix for sata_mv >64KB DMA segments
- Previous by thread: Re: [PATCH] sky2: jumbo frame regression fix
- Next by thread: Re: [PATCH] sky2: jumbo frame regression fix
- Index(es):
 |