On Wed, 2007-10-03 at 10:26 +1000, Tony Breeds wrote: > On Tue, Oct 02, 2007 at 06:28:19PM -0500, Linas Vepstas wrote: > > On Mon, Sep 24, 2007 at 01:35:31PM +0100, Andy Whitcroft wrote: > > > Seeing the following from an older power LPAR, pretty sure we had > > > this in the previous -mm also: > > > > I haven't forgetten about this ... and am looking at it now. > > Seems that whenever I go to reserve the machine pSeries-102, > > someone else is using it :-) > > This panic is caused by "[POWERPC] pseries: Fix jumbled no_logging flag." > (79c0108d1b9db4864ab77b2a95dfa04f2dcf264c), in the powerpc/for-2.6.24 > branch. It looks to me that we have logging enabled too early now. > > I think the following is a reasonable fix? > > --- > Explicitly enable RTAS error logging, when it should be ready. > > > Signed-off-by: Tony Breeds <[email protected]> > > --- > > arch/powerpc/platforms/pseries/rtasd.c | 7 ++++++- > 1 files changed, 6 insertions(+), 1 deletions(-) > > diff --git a/arch/powerpc/platforms/pseries/rtasd.c b/arch/powerpc/platforms/pseries/rtasd.c > index 30925d2..0df5d0d 100644 > --- a/arch/powerpc/platforms/pseries/rtasd.c > +++ b/arch/powerpc/platforms/pseries/rtasd.c > @@ -54,7 +54,10 @@ static unsigned int rtas_event_scan_rate; > static int full_rtas_msgs = 0; > > /* Stop logging to nvram after first fatal error */ > -static int no_more_logging; > +static int no_more_logging = 1; /* Until we initialize everything, > + * make sure we don't try logging > + * anything */ > + I realise it'll make the patch bigger, but this doesn't seem like a particularly good name for the variable anymore. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person
Attachment:
signature.asc
Description: This is a digitally signed message part
- Follow-Ups:
- Re: 2.6.23-rc7-mm1 -- powerpc rtas panic
- From: [email protected] (Tony Breeds)
- Re: 2.6.23-rc7-mm1 -- powerpc rtas panic
- References:
- Re: 2.6.23-rc7-mm1 -- powerpc rtas panic
- From: [email protected] (Linas Vepstas)
- Re: 2.6.23-rc7-mm1 -- powerpc rtas panic
- From: [email protected] (Tony Breeds)
- Re: 2.6.23-rc7-mm1 -- powerpc rtas panic
- Prev by Date: Re: build error
- Next by Date: Re: kswapd min order, slub max order [was Re: -mm merge plans for 2.6.24]
- Previous by thread: Re: 2.6.23-rc7-mm1 -- powerpc rtas panic
- Next by thread: Re: 2.6.23-rc7-mm1 -- powerpc rtas panic
- Index(es):
 |