Re: [PATCH 11/30] IGET: Stop EXT2 from using iget() and read_inode()

> diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
> index 0079b2c..d8fb795 100644
> --- a/fs/ext2/inode.c
> +++ b/fs/ext2/inode.c
...
> +
> +	raw_inode = ext2_get_inode(inode->i_sb, ino, &bh);
>  	if (IS_ERR(raw_inode))
>   		goto bad_inode;
  Hmm, why don't you use the return value from raw_inode? It can be
either -EIO or -EINVAL if 'ino' was invalid...
  Otherwise the patch looks fine.

								Honza
-- 
Jan Kara <[email protected]>
SuSE CR Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 00/30] Remove iget() and read_inode()
    • From: David Howells <[email protected]>
  • [PATCH 11/30] IGET: Stop EXT2 from using iget() and read_inode()
    • From: David Howells <[email protected]>

• Prev by Date: Re: Promise SATA300 TX4: errors, oops in ext3 code
• Next by Date: Re: [patch] printk: add KERN_CONT annotation
• Previous by thread: [PATCH 11/30] IGET: Stop EXT2 from using iget() and read_inode()
• Next by thread: Re: [PATCH 11/30] IGET: Stop EXT2 from using iget() and read_inode()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]