On Saturday 29 September 2007, you wrote:
> +static inline u64 compat_merge64(u32 left, u32 right)
> +{
> +#if defined(__BIG_ENDIAN)
> + return ((u64)left << 32) | right;
> +#else /* defined (__LITTLE_ENDIAN) */
> + return ((u64)right << 32) | left;
> +#endif
> +}
Looks good, if we can guarantee that
1. Byte order matches the order in which 64 bit arguments are split
in system call conventions on all platforms.
2. Every user of compat_merge64() includes asm/byteorder.h
Both should be easy to prove, but I'm not convinced until someone
actually does it.
Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
