Re: [PATCH] spin_lock_unlocked cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Andrew Morton <[email protected]> wrote:

> On Fri, 28 Sep 2007 10:17:30 +0200 Thomas Gleixner <[email protected]> wrote:
> 
> > can we please add this to checkpatch.pl ? 
> > 
> > > -spinlock_t bpci_lock = SPIN_LOCK_UNLOCKED;
> > > +DEFINE_SPINLOCK(bpci_lock);
> 
> That check is already in checkpatch.  Problem is that hardly anyone 
> runs the thing.

i automatically run it for every patch i submit or push out via git.

> I think we're ready to wire checkpatch up to a email robot which 
> monitors the mailing lists and sends people nastygrams.  I bet that'll 
> be popular ;)

heh ;-) It could be automated for patches that are sent out with a 
Signed-off-by [or a Reviewed-by] line. If you send a SoB patch that is 
broken, prepare to get a nastygram. (Initially i'd suggest the nastygram 
to Cc: to a different email list, not lkml.)

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux