Re: [PATCH 1/4] dma: add dma_flags_set_dmaflush() to dma interface

On Tue, Sep 25, 2007 at 10:13:33PM -0700, Randy Dunlap wrote:
> On Tue, 25 Sep 2007 17:00:57 -0700 [email protected] wrote:
> ......
> 1.  Function signature should be on one line if possible (and it is).
> Aw crud, I looked at dma-mapping.h and it uses this format sometimes.
> Well, it's undesirable, so please don't propagate it.
> 
> 2.  No parens on return: it's not a function.
> 
> static inline int dma_flags_set_dmaflush(int dir)
> {
> 	return dir;
> }
> 
> 
> Similar comments for patch 2/4: sn-ia64.
> 

Both fixed in next version. Thanks, Randy.

-- 
Arthur

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 1/4] dma: add dma_flags_set_dmaflush() to dma interface
    • From: [email protected]
  • Re: [PATCH 1/4] dma: add dma_flags_set_dmaflush() to dma interface
    • From: Randy Dunlap <[email protected]>

• Prev by Date: Re: More E820 brokenness
• Next by Date: Re: [PATCH 0/4] allow drivers to flush in-flight DMA
• Previous by thread: Re: [PATCH 1/4] dma: add dma_flags_set_dmaflush() to dma interface
• Next by thread: [PATCH 2/4] dma: redefine dma_flags_set_dmaflush() for sn-ia64
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]