Re: 2.6.23-rc8-mm2: problems on HP nx6325

[Sam Ravnborg <sam@ravnborg.org>]

Hi Rafael.
> 
> Fix CPU hotplug breakage on HP nx6325 and similar boxes caused by a reference
> to disable_apic_timer (labeled as __initdata) from the CPU initialization code.
> 
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> ---
>  arch/x86_64/kernel/apic.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6.23-rc8-mm2/arch/x86_64/kernel/apic.c
> ===================================================================
> --- linux-2.6.23-rc8-mm2.orig/arch/x86_64/kernel/apic.c
> +++ linux-2.6.23-rc8-mm2/arch/x86_64/kernel/apic.c
> @@ -42,7 +42,7 @@
>  
>  int apic_verbosity;
>  static int apic_calibrate_pmtmr __initdata;
> -int disable_apic_timer __initdata;
> +int disable_apic_timer __cpuinitdata;
>  
This is with your configuration a reference from a .text section
to a .init.data section as I see it.

So this ought to have been flagged by the section mismatch
checks in modpost.

I assume you did not see such warning??

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/