Re: xpad_probe: undefined reference to `led_classdev_register'

[Randy Dunlap <randy.dunlap@oracle.com>]

On Wed, 26 Sep 2007 18:33:22 -0400 Dmitry Torokhov wrote:

> Hi,
> 
> On Wednesday 26 September 2007, Randy Dunlap wrote:
> > On Wed, 26 Sep 2007 23:25:33 +0200 thomas@m3y3r.de wrote:
> > 
> > > Hi.
> > > 
> > > Current linus' git tree:
> > > 
> > > x86_64-unknown-linux-gnu-ld: BFD 2.15 assertion fail
> > > /home/thomas/source/crosstool-0.43/build/x86_64-unknown-linux-gnu/gcc-3.4.5-glibc-2.3.6/binutils-2.15/bfd/linker.c:619
> > > drivers/built-in.o(.text+0x20749d): In function `xpad_probe':
> > > : undefined reference to `led_classdev_register'
> > > drivers/built-in.o(.text+0x20756c): In function `xpad_disconnect':
> > > : undefined reference to `led_classdev_unregister'
> > > make: *** [.tmp_vmlinux1] Fehler 1
> > > 
> > > any ideas?
> > 
> > Please send .config file.
> > 
> > Ix xpad driver built-in (yes, it is) and led driver is modular?
> > We can fix that...
> >
> 
> I have the patch below in mytree. I guess I need to forward it to Linus
> insterad of waiting for 2.6.24 as too many people hit this.
> 
> -- 
> Dmitry
>  
> Input: xpad - fix dependancy on LEDS class
> 
> The driver can not be built-in when LEDS class is a module.
> 
> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

Yes, looks good.  Thanks.

> ---
>  drivers/input/joystick/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: work/drivers/input/joystick/Kconfig
> ===================================================================
> --- work.orig/drivers/input/joystick/Kconfig
> +++ work/drivers/input/joystick/Kconfig
> @@ -277,7 +277,7 @@ config JOYSTICK_XPAD_FF
>  
>  config JOYSTICK_XPAD_LEDS
>  	bool "LED Support for Xbox360 controller 'BigX' LED"
> -	depends on LEDS_CLASS && JOYSTICK_XPAD
> +	depends on JOYSTICK_XPAD && (LEDS_CLASS=y || LEDS_CLASS=JOYSTICK_XPAD)
>  	---help---
>  	  This option enables support for the LED which surrounds the Big X on
>  	  XBox 360 controller.
> -

---
~Randy
Phaedrus says that Quality is about caring.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/